Skip to content

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Sep 29, 2025

  • Updated index.mdx content
  • Remove placeholder items from S2 migration guide
  • Added horizontal scrolling to mobile search menu's tag group
  • Updated markdown docs script to handle more custom cases
  • Added tags to search logic
  • Improved mobile search menu experience
  • Fixes from testing

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Sep 29, 2025

@snowystinger
Copy link
Member

weird, the S2 docs didn't build?

@rspbot
Copy link

rspbot commented Sep 29, 2025

selectedKeys={selectedSection ? [selectedSection] : []}
onSelectionChange={handleTagSelection}
styles={style({margin: 12})}
UNSAFE_style={{overflow: 'auto', whiteSpace: 'nowrap', paddingBlock: 8}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@rspbot
Copy link

rspbot commented Sep 30, 2025

LFDanLu
LFDanLu previously approved these changes Sep 30, 2025
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provisional approval pending intro page content

## Another H2

### Another H3
The existing docs are still available [here](https://react-spectrum.adobe.com/react-spectrum/index.html). We plan to do a full release of the new docs site by early 2026, so we welcome any and all feedback!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dannify does this date line up with our road map or do we wanna be more vague?

@rspbot
Copy link

rspbot commented Sep 30, 2025

@rspbot
Copy link

rspbot commented Oct 1, 2025

@rspbot
Copy link

rspbot commented Oct 1, 2025

@rspbot
Copy link

rspbot commented Oct 1, 2025

@yihuiliao
Copy link
Member

seems like the scrollbar is covered partially by taggroup
IMG_2044

is the searchfield supposed to fixed? when i drag my finger to scroll down and hold it, everything scrolls except for the searchfield + taggroup
IMG_2045

this is also on iOS 18, not sure if it's different for iOS 26

@rspbot
Copy link

rspbot commented Oct 1, 2025

@rspbot
Copy link

rspbot commented Oct 1, 2025

@rspbot
Copy link

rspbot commented Oct 1, 2025

@snowystinger
Copy link
Member

snowystinger commented Oct 1, 2025

Heh, similar to Yihui, but for me, the search is off the screen to the bottom and i can't get to it
IMG_2153

@reidbarber
Copy link
Member Author

@snowystinger Interesting, I'm not seeing that behavior on the latest commit in iOS 26. @yihuiliao If you have a chance, can you give the latest build another try to see if you're seeing the same?

@snowystinger
Copy link
Member

@snowystinger Interesting, I'm not seeing that behavior on the latest commit in iOS 26. @yihuiliao If you have a chance, can you give the latest build another try to see if you're seeing the same?

I just updated my phone to the next Tahoe version and it seems to be resolved. I'm going to say this was a Safari issue.

selectionMode="single"
selectedKeys={selectedSection ? [selectedSection] : []}
onSelectionChange={handleTagSelection}
UNSAFE_style={{whiteSpace: 'nowrap'}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if we should just support a non-wrapping, non-collapsing tag group
Also, I tried this with maxRows={1} and I think it's fine, when you click show all it just goes to the next line

IMG_2155
IMG_2154

Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mobile search looks a lot better on my phone!

@reidbarber reidbarber added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit 04bd079 Oct 1, 2025
32 checks passed
@reidbarber reidbarber deleted the s2-docs-more-2 branch October 1, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants